[
https://issues.apache.org/jira/browse/YARN-1651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740717#comment-14740717
]
Jian He edited comment on YARN-1651 at 9/11/15 12:43 PM:
---------------------------------------------------------
few more comments:
- schedulerNode#increaseContainer is not invoked when increasing regular
container ? add a test?
- remove ContainersAndNMTokensAllocation in SchedulerApplicationAttempt
- FiCaSchedulerApp#unreserve -> unreserveIncreasedContainer to avoid name
confliction.
{code}
public boolean unreserve(Priority priority,
FiCaSchedulerNode node, RMContainer rmContainer) {
{code}
- revert RMWebServices, AssignmentInformation changes
- MockAM#allocateChangeContainerRequests -> resizeContainers
- very long line in FairScheduler and FifoScheduler
{code} List<String> blacklistAdditions, List<String> blacklistRemovals,
List<ContainerResourceChangeRequest> increaseRequests,
List<ContainerResourceChangeRequest> decreaseRequests) {
{code}
was (Author: jianhe):
few more comments:
- schedulerNode#increaseContainer is not invoked when increasing regular
container ? add a test?
- remove ContainersAndNMTokensAllocation in SchedulerApplicationAttempt
- FiCaSchedulerApp#unreserve -> unreserveIncreasedContainer to avoid name
confliction.
{code}
public boolean unreserve(Priority priority,
FiCaSchedulerNode node, RMContainer rmContainer) {
{code}
- revert RMWebServices, AssignmentInformation changes
- MockAM#allocateChangeContainerRequests -> resizeContainers
> CapacityScheduler side changes to support increase/decrease container
> resource.
> -------------------------------------------------------------------------------
>
> Key: YARN-1651
> URL: https://issues.apache.org/jira/browse/YARN-1651
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager, scheduler
> Reporter: Wangda Tan
> Assignee: Wangda Tan
> Attachments: YARN-1651-1.YARN-1197.patch,
> YARN-1651-2.YARN-1197.patch, YARN-1651-3.YARN-1197.patch,
> YARN-1651-4.YARN-1197.patch, YARN-1651-5.YARN-1197.patch,
> YARN-1651-6.YARN-1197.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)