[ 
https://issues.apache.org/jira/browse/YARN-4149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14744566#comment-14744566
 ] 

Xuan Gong commented on YARN-4149:
---------------------------------

Thanks, [~vvasudev] The patch looks good overall. One nit:
* Could you check whether the logFiles array contains "ALL" instead of just 
checking whether "ALL" is the first item in logFiles array?
* Could you comment whether the testcase failures/findbug are related or not ?

> yarn logs -am should provide an option to fetch all the log files
> -----------------------------------------------------------------
>
>                 Key: YARN-4149
>                 URL: https://issues.apache.org/jira/browse/YARN-4149
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: client, nodemanager
>    Affects Versions: 2.7.1
>            Reporter: Varun Vasudev
>            Assignee: Varun Vasudev
>         Attachments: YARN-4149.001.patch, YARN-4149.002.patch
>
>
> From [~gopalv] -
> {quote}
> Trying to collect a hanging Tez AM logs, by killing the container and running 
> yarn logs -applicationId application_1437098194051_0178 -am ALL
> The output contains only one log file, which does not contain any of the 
> actual execution logs, only the initialization logs.
> From YARN-3347, I note that
>       // if we do not specify the value for CONTAINER_LOG_FILES option,
>      // we will only output syslog
> This means that the person calling the yarn logs command has to list it out 
> like this, to collect logs 
> yarn logs -applicationId application_1437098194051_0178 -am ALL -logFiles \
> syslog_dag_1437098194051_0178_2_post,\
> dag_1437098194051_0178_2-tez-dag.pb.txt,\
> syslog_dag_1437098194051_0178_2,\
> syslog_dag_1437098194051_0178_1_post,\
> syslog_dag_1437098194051_0178_1,\
> syslog,\
> stdout,\
> stderr,\
> dag_1437098194051_0178_2.dot,\
> dag_1437098194051_0178_1.dot,\
> dag_1437098194051_0178_1-tez-dag.pb.txt
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to