[
https://issues.apache.org/jira/browse/YARN-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Advertising
zhihai xu updated YARN-4158:
----------------------------
Description:
Remove duplicate {{close}} for {{LogWriter}} in
{{AppLogAggregatorImpl#uploadLogsForContainers}}
{{writer.close()}} was called twice in {{uploadLogsForContainers}}. One is
called at the middle of the function and the other one is called at finally
block. It will be better to just close {{writer}} once.
was:
Remove duplicate {{close}} for {{LogWriter}} in
{{AppLogAggregatorImpl#uploadLogsForContainers}}
{{writer.close()}} was called twice in {{uploadLogsForContainers}}. One is
called at the middle of the function and the other one is called at finally
block.
It will be better to close {{writer}} once.
> Remove duplicate close for LogWriter in
> AppLogAggregatorImpl#uploadLogsForContainers
> ------------------------------------------------------------------------------------
>
> Key: YARN-4158
> URL: https://issues.apache.org/jira/browse/YARN-4158
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.7.0
> Reporter: zhihai xu
> Assignee: zhihai xu
> Priority: Trivial
> Labels: cleanup
> Attachments: YARN-4158.000.patch
>
>
> Remove duplicate {{close}} for {{LogWriter}} in
> {{AppLogAggregatorImpl#uploadLogsForContainers}}
> {{writer.close()}} was called twice in {{uploadLogsForContainers}}. One is
> called at the middle of the function and the other one is called at finally
> block. It will be better to just close {{writer}} once.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
