[ 
https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14745242#comment-14745242
 ] 

Varun Saxena commented on YARN-4000:
------------------------------------

Thanks [~jianhe] for the review. 
Regarding appDiagnosticsBeforeKilling, it was used because we normally update 
diagnostics only after it has been stored in state store i.e. in FINAL_SAVING 
transition. And this step would happen only after attempt has been killed. At 
this point we do not have access to original app kill event.

Is it fine to update the diagnostics when app is in KILLING state ? I guess 
should be. Your thoughts ?

> RM crashes with NPE if leaf queue becomes parent queue during restart
> ---------------------------------------------------------------------
>
>                 Key: YARN-4000
>                 URL: https://issues.apache.org/jira/browse/YARN-4000
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacityscheduler, resourcemanager
>    Affects Versions: 2.6.0
>            Reporter: Jason Lowe
>            Assignee: Varun Saxena
>         Attachments: YARN-4000.01.patch, YARN-4000.02.patch
>
>
> This is a similar situation to YARN-2308.  If an application is active in 
> queue A and then the RM restarts with a changed capacity scheduler 
> configuration where queue A becomes a parent queue to other subqueues then 
> the RM will crash with a NullPointerException.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to