[ https://issues.apache.org/jira/browse/YARN-4078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14745247#comment-14745247 ]
Hadoop QA commented on YARN-4078: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 16m 12s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 3 new or modified test files. | | {color:green}+1{color} | javac | 7m 38s | There were no new javac warning messages. | | {color:red}-1{color} | javadoc | 9m 44s | The applied patch generated 1 additional warning messages. | | {color:green}+1{color} | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 0m 47s | There were no new checkstyle issues. | | {color:red}-1{color} | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. | | {color:green}+1{color} | install | 1m 27s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 1m 28s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:red}-1{color} | yarn tests | 54m 37s | Tests failed in hadoop-yarn-server-resourcemanager. | | | | 92m 51s | | \\ \\ || Reason || Tests || | Failed unit tests | hadoop.yarn.server.resourcemanager.scheduler.fair.TestAllocationFileLoaderService | | | hadoop.yarn.server.resourcemanager.webapp.TestRMWebServicesDelegationTokenAuthentication | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12755952/YARN-4078.20150915.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / d777757 | | javadoc | https://builds.apache.org/job/PreCommit-YARN-Build/9140/artifact/patchprocess/diffJavadocWarnings.txt | | whitespace | https://builds.apache.org/job/PreCommit-YARN-Build/9140/artifact/patchprocess/whitespace.txt | | hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/9140/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/9140/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/9140/console | This message was automatically generated. > getPendingResourceRequestForAttempt is present in AbstractYarnScheduler > should be present in YarnScheduler interface instead > ----------------------------------------------------------------------------------------------------------------------------- > > Key: YARN-4078 > URL: https://issues.apache.org/jira/browse/YARN-4078 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager > Reporter: Naganarasimha G R > Assignee: Naganarasimha G R > Priority: Minor > Attachments: YARN-4078.20150915.patch > > > Currently getPendingResourceRequestForAttempt is present in > {{AbstractYarnScheduler}}. > *But in AppInfo, we are calling this method by typecasting it to > AbstractYarnScheduler, which is incorrect.* > Because if a custom scheduler is to be added, it will implement > YarnScheduler, not AbstractYarnScheduler. > This method should be moved to YarnScheduler or it should have a guarded > check like in other places (RMAppAttemptBlock.getBlackListedNodes) -- This message was sent by Atlassian JIRA (v6.3.4#6332)