Sunil G commented on YARN-4044:

Hi [~Naganarasimha Garla]
Yes. we can add more events in test case to verify the order, this can be done. 
I will update.
As I see point 2, all {{SystemMetricsEvent}} are overriding {{hashCode}} along 
with the new {{ApplicationUpdatedEvent}}. And if you see 
{{AppAttemptRegisteredEvent}}, there also the hashCode is overridden with 
*appId*, not *appAttemptId*.
  public int hashCode() {
    return appAttemptId.getApplicationId().hashCode();
Also sharing code snippet from {{ContainerCreatedEvent}}
  public int hashCode() {
    return containerId.getApplicationAttemptId().getApplicationId().hashCode();

So the intention looks like is to treat all {{SystemMetricsEvent}} similar I 
feel. [~rohithsharma] thoughts?

> Running applications information changes such as movequeue is not published 
> to TimeLine server
> ----------------------------------------------------------------------------------------------
>                 Key: YARN-4044
>                 URL: https://issues.apache.org/jira/browse/YARN-4044
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager, timelineserver
>    Affects Versions: 2.7.0
>            Reporter: Sunil G
>            Assignee: Sunil G
>            Priority: Critical
>         Attachments: 0001-YARN-4044.patch, 0002-YARN-4044.patch, 
> 0003-YARN-4044.patch, 0004-YARN-4044.patch
> SystemMetricsPublisher need to expose an appUpdated api to update any change 
> for a running application.
> Events can be 
>       - change of queue for a running application.
>         - change of application priority for a running application.
> This ticket intends to handle both RM and timeline side changes. 

This message was sent by Atlassian JIRA

Reply via email to