Jason Lowe commented on YARN-3975:

Thanks for updating the patch, Mit!  Looks good overall with just two nits left.

The error message for an app that's not found now has an extraneous comma as it 
will now say, "Application application_1234_1 could not be found, in RM or 
history server".

We should probably throw an UnsupportedOperationException or something similar 
when the app report source isn't RM or AHS.  Shouldn't happen now but could if 
someone comes along and adds a new enum value and forgets to update this code.  
If it does happen the code will just do nothing as-is.

> WebAppProxyServlet should not redirect to RM page if AHS is enabled
> -------------------------------------------------------------------
>                 Key: YARN-3975
>                 URL: https://issues.apache.org/jira/browse/YARN-3975
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.7.1
>            Reporter: Mit Desai
>            Assignee: Mit Desai
>         Attachments: YARN-3975.2.b2.patch, YARN-3975.3.patch, 
> YARN-3975.4.patch, YARN-3975.5.patch, YARN-3975.6.patch, YARN-3975.7.patch
> WebAppProxyServlet should be updated to handle the case when the appreport 
> doesn't have a tracking URL and the Application History Server is eanbled.
> As we would have already tried the RM and got the 
> ApplicationNotFoundException we should not direct the user to the RM app page.

This message was sent by Atlassian JIRA

Reply via email to