[
https://issues.apache.org/jira/browse/YARN-4180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876583#comment-14876583
]
Robert Kanter commented on YARN-4180:
-------------------------------------
Looks good. Two minor things:
- Can you look into the test failure to see if it's related
- Instead of the {{// Exposed for testing}} comment, you can put
{{@VisibleForTesting}}
> AMLauncher does not retry on failures when talking to NM
> ---------------------------------------------------------
>
> Key: YARN-4180
> URL: https://issues.apache.org/jira/browse/YARN-4180
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
> Affects Versions: 2.7.1
> Reporter: Anubhav Dhoot
> Assignee: Anubhav Dhoot
> Priority: Critical
> Attachments: YARN-4180.001.patch
>
>
> We see issues with RM trying to launch a container while a NM is restarting
> and we get exceptions like NMNotReadyException. While YARN-3842 added retry
> for other clients of NM (AMs mainly) its not used by AMLauncher in RM causing
> there intermittent errors to cause job failures. This can manifest during
> rolling restart of NMs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
