[
https://issues.apache.org/jira/browse/YARN-4176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900185#comment-14900185
]
Naganarasimha G R commented on YARN-4176:
-----------------------------------------
Hi [~bibinchundatt],
Thanks for working on the patch. Few comments :
NodeStatusUpdaterImpl.java
# {{diffcheckstylehadoop-yarn-server-nodemanager.txt}} seems like issues
reported here are related to the modifications of the patch
# {{areNodeLabelsUpdated || resyncElapsed}} could be {{areNodeLabelsUpdated ||
isResyncIntervalElapsed()}}, In the cases where node labels are updated then
due to short circuit isResyncIntervalElapsed will be avoided
# in {{isResyncIntervalElapsed}} resyncInterval need not be evaluated on every
call we can push this to constructor or init
> Resync NM nodelabels with RM every x interval for distributed nodelabels
> ------------------------------------------------------------------------
>
> Key: YARN-4176
> URL: https://issues.apache.org/jira/browse/YARN-4176
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Bibin A Chundatt
> Assignee: Bibin A Chundatt
> Attachments: 0001-YARN-4176.patch, 0002-YARN-4176.patch,
> 0003-YARN-4176.patch
>
>
> This JIRA is for handling the below set of issue
> # Distributed nodelabels after NM registered with RM if cluster nodelabels
> are removed and added then NM doesnt resend labels in heartbeat again untils
> any change in labels
> # NM registration failed with Nodelabels should resend labels again to RM
> The above cases can be handled by resync nodeLabels with RM every x interval
> # Add property {{yarn.nodemanager.node-labels.provider.resync-interval-ms}}
> and will resend nodelabels to RM based on config no matter what the
> registration fails or success.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
