Naganarasimha G R updated YARN-4169:
    Attachment: YARN-4169.v1.001.patch

Hi [~ste...@apache.org],
   Was able to reproduce this test failure (NPE) during debug testing, and it 
was due to improper handling of race condition, basically after sending 
{{hearbeat}} we need to wait for a short duration in the test case for the HB 
thread in Node status updater, till it goes into wait state. If some sleep is 
not added then notify of {{sendOutofBandHeartBeat}} will be called even before 
HB thread  goes to wait state. Also have corrected other review comments which 
you had mentioned.

> jenkins trunk+java build failed in TestNodeStatusUpdaterForLabels
> -----------------------------------------------------------------
>                 Key: YARN-4169
>                 URL: https://issues.apache.org/jira/browse/YARN-4169
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>         Environment: Jenkins
>            Reporter: Steve Loughran
>            Assignee: Naganarasimha G R
>            Priority: Critical
>         Attachments: YARN-4169.v1.001.patch
> Test failing in [[Jenkins build 
> 402|https://builds.apache.org/view/H-L/view/Hadoop/job/Hadoop-Yarn-trunk-Java8/402/testReport/junit/org.apache.hadoop.yarn.server.nodemanager/TestNodeStatusUpdaterForLabels/testNodeStatusUpdaterForNodeLabels/]
> {code}
> java.lang.NullPointerException: null
>       at java.util.HashSet.<init>(HashSet.java:118)
>       at 
> org.apache.hadoop.yarn.nodelabels.NodeLabelTestBase.assertNLCollectionEquals(NodeLabelTestBase.java:103)
>       at 
> org.apache.hadoop.yarn.server.nodemanager.TestNodeStatusUpdaterForLabels.testNodeStatusUpdaterForNodeLabels(TestNodeStatusUpdaterForLabels.java:268)
> {code}

This message was sent by Atlassian JIRA

Reply via email to