[
https://issues.apache.org/jira/browse/YARN-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14908456#comment-14908456
]
MENG DING commented on YARN-1510:
---------------------------------
One thing I want to bring up for discussion is that this ticket adds two
methods to the public callback interface {{NMClientAsync.CallbackHandler}}.
This means if user wants to rebuild their ApplicationMaster against the new
client library, they will have to modify their code to implement these two
methods. I don't see a way around this unless we don't want to add these two
methods.
{code}
+ /**
+ * The API is called when <code>NodeManager</code> responds to indicate
+ * the container resource has been successfully increased.
+ * @param containerId the Id of the container
+ * @param resource the target resource of the container
+ */
+ void onContainerResourceIncreased(
+ ContainerId containerId, Resource resource);
+ /**
+ * The API is called when an exception is raised in the process of
+ * increasing container resource.
+ * @param containerId the Id of the container
+ * @param t the raised exception
+ */
+ void onIncreaseContainerResourceError(
+ ContainerId containerId, Throwable t);
{code}
> Make NMClient support change container resources
> ------------------------------------------------
>
> Key: YARN-1510
> URL: https://issues.apache.org/jira/browse/YARN-1510
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Wangda Tan (No longer used)
> Assignee: MENG DING
> Attachments: YARN-1510-YARN-1197.1.patch,
> YARN-1510-YARN-1197.2.patch, YARN-1510.3.patch
>
>
> As described in YARN-1197, YARN-1449, we need add API in NMClient to support
> 1) sending request of increase/decrease container resource limits
> 2) get succeeded/failed changed containers response from NM.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
