[ 
https://issues.apache.org/jira/browse/YARN-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933726#comment-14933726
 ] 

Vrushali C commented on YARN-4203:
----------------------------------

Thanks [~varun_saxena], patch looks good to me. 
+ 1

One minor suggestion, we need not make it right now if there are no other 
changes. 
The log statement right now is ""URL " + url + " processed." or "URL " + url + 
" received".  Perhaps we could make it  "Received URL " + url and "Processed 
URL " + url. 

While browsing through the logs, it helps scan things visually faster. Also, if 
we have scripts parsing the logs, it is easier to parse out lines starting with 
"Received" or "Processed". 



> Add request/response logging & timing for each REST endpoint call
> -----------------------------------------------------------------
>
>                 Key: YARN-4203
>                 URL: https://issues.apache.org/jira/browse/YARN-4203
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Vrushali C
>            Assignee: Varun Saxena
>            Priority: Minor
>         Attachments: YARN-4203-YARN-2928.01.patch
>
>
> The rest endpoints are being added as part of YARN-4075. Filing this jira to 
> add in request & response logging and timing for each REST call that comes 
> in. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to