[
https://issues.apache.org/jira/browse/YARN-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934342#comment-14934342
]
Wangda Tan commented on YARN-4172:
----------------------------------
Haven't finished all review, some comments so far:
1) Who will update DRC.resourceNames, I found currently it hardcoded to memory
and vcores.
2) DominantResourceCalculator#compare:
- Need handle the case when resourceName not existed at lhs or rhs?
- Could use ResourceInformation.compareTo instead of
ResourceInformation.compareValue since resourceName equals to each other? Is it
still necessary to keep compareValue?
3) Suggest to use > = < to do compare since of {{switch (diff)}}.
4) DRC#computeAvailableContainers need consider denominator == 0?
5) Is it possible we can return a dummy ResourceInformation (with value == 0)
instead of check exception at lots of places:
{code}
catch (YarnException ye) {
throw new IllegalArgumentException(
"Error getting resource information for " + resource, ye);
}
{code}
> Extend DominantResourceCalculator to account for all resources
> --------------------------------------------------------------
>
> Key: YARN-4172
> URL: https://issues.apache.org/jira/browse/YARN-4172
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Varun Vasudev
> Assignee: Varun Vasudev
> Attachments: YARN-4172-YARN-3926.001.patch
>
>
> Now that support for multiple resources is present in the resource class, we
> need to modify DominantResourceCalculator to account for the new resources.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
