MENG DING commented on YARN-1509:

Thanks for the review [~leftnoteasy]!

bq. I think we can simply add decreaseList to decrease and increaseList to 

In most cases, the current logic effectively adds decreaseList to decrease map, 
and increaseList to increase map. But since the allocate call 
{{allocateResponse = allocate(progressIndicator)}} is not synchronized, during 
the allocation, new increase/decrease requests may have been added to the 
increase/decrease table, which IMO should not be overwritten by the old 
requests cached in increaseList and decreaseList. This is similar to the new 
container requests logic when allocation fails. Let me know if you think 

bq,  if request matches, we can print some logs to show this

Will do.

> Make AMRMClient support send increase container request and get 
> increased/decreased containers
> ----------------------------------------------------------------------------------------------
>                 Key: YARN-1509
>                 URL: https://issues.apache.org/jira/browse/YARN-1509
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan (No longer used)
>            Assignee: MENG DING
>         Attachments: YARN-1509.1.patch, YARN-1509.2.patch
> As described in YARN-1197, we need add API in AMRMClient to support
> 1) Add increase request
> 2) Can get successfully increased/decreased containers from RM

This message was sent by Atlassian JIRA

Reply via email to