[ 
https://issues.apache.org/jira/browse/YARN-3864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940420#comment-14940420
 ] 

Sangjin Lee commented on YARN-3864:
-----------------------------------

Thanks for the patch [~varun_saxena]! I'm away from the desk, and I'll 
communicate quick feedback.

The URL patterns of the new endpoints seem bit unnatural. For example, "/apps" 
comes before the flow id and the flow run id. Does this conform to the normal 
REST style? IIUC, they usually follow the direction of the narrowing scope, 
right? For example, the current YARN REST API follows that style (app -> app 
attempt -> container). Should we make our REST API consistent with that style?

(TimelineEntityReader.java)
- l.82: nit: I think sortedKeys can/should be private


> Implement support for querying single app and all apps for a flow run
> ---------------------------------------------------------------------
>
>                 Key: YARN-3864
>                 URL: https://issues.apache.org/jira/browse/YARN-3864
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>            Priority: Blocker
>         Attachments: YARN-3864-YARN-2928.01.patch
>
>
> This JIRA will handle support for querying all apps for a flow run in HBase 
> reader implementation.
> And also REST API implementation for single app and multiple apps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to