[ 
https://issues.apache.org/jira/browse/YARN-3864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14943645#comment-14943645
 ] 

Sangjin Lee commented on YARN-3864:
-----------------------------------

I kicked off another jenkins build.

I have reviewed the latest patch (v.3), and it looks good to me for the most 
part. I have only a few minor comments.

(TimelineReaderWebServices.java)
- l.540: nit: let's use a normal Java style: {{req.getQueryString() == null}}
- l.575: If we're calling this end point "flowrunapps", then shouldn't the 
method be called {{getFlowRunApps}}? The latter one seems to be named that.
- Both for /flowrunapps and /flowapps, I understand it will return the most 
recent N apps if item is specified, correct? Then it should be stated in the 
javadoc.

If you could address those, and with jenkins passing, I'd like to go ahead and 
commit the patch. Do let me know if you have other comments. Thanks!

> Implement support for querying single app and all apps for a flow run
> ---------------------------------------------------------------------
>
>                 Key: YARN-3864
>                 URL: https://issues.apache.org/jira/browse/YARN-3864
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>            Priority: Blocker
>         Attachments: YARN-3864-YARN-2928.01.patch, 
> YARN-3864-YARN-2928.02.patch, YARN-3864-YARN-2928.03.patch, 
> YARN-3864-addendum-appaggregation.patch
>
>
> This JIRA will handle support for querying all apps for a flow run in HBase 
> reader implementation.
> And also REST API implementation for single app and multiple apps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to