[
https://issues.apache.org/jira/browse/YARN-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944313#comment-14944313
]
Wangda Tan commented on YARN-4215:
----------------------------------
Thanks [~Naganarasimha]! Patch generally looks good to me,
Only a few nits in the test:
- I suggest to add one more test just to avoid regression in the future: If a
host has label (node1:0 label=x). If someone update label of node1:0 to y.
Scheduler should receive an event as well.
- Could you check if labels of the events are expected?
{code}
483 mgr.replaceLabelsOnNode(ImmutableMap.of(toNodeId("n1:1"),
toSet("p1"),
484 toNodeId("n2:1"), toSet("p2"), toNodeId("n3"), toSet("p3")));
485 assertTrue("Event should be sent when there is change in labels",
486 schedEventsHandler.receivedEvent);
487 assertEquals("3 node label mapping modified", 3,
488 schedEventsHandler.updatedNodeToLabels.size());
489 schedEventsHandler.receivedEvent = false;
{code}
> RMNodeLabels Manager Need to verify and replace node labels for the only
> modified Node Label Mappings in the request
> --------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-4215
> URL: https://issues.apache.org/jira/browse/YARN-4215
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Labels: nodelabel, resourcemanager
> Attachments: YARN-4215.v1.001.patch
>
>
> Modified node Labels needs to be updated by the capacity scheduler holding a
> lock hence its better to push events to scheduler only when there is actually
> a change in the label mapping for a given node.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
