Bikas Saha commented on YARN-1509:

Sorry for coming in late on this. I have some questions on the API.

Why are there separate methods for increase and decrease instead of a single 
method to change the container resource size? By comparing the existing 
resource allocation to a container and the new requested resource allocation, 
it should be clear whether an increase or decrease is being requested.

Also, for completeness, is there a need for a cancelContainerResourceChange()? 
After a container resource change request has been submitted, what are my 
options as a user other than to wait for the request to be satisfied by the RM? 

If I release the container, then does it mean all pending change requests for 
that container should be removed? From a quick look at the patch, it does not 
look like that is being covered, unless I am missing something.

What will happen if the AM restarts after submitting a change request. Does the 
AM-RM re-register protocol need an update to handle the case of 
re-synchronizing on the change requests? Whats happens if the RM restarts? If 
these are explained in a document, then please point me to the document. The 
patch did not seem to have anything around this area. So I thought I would ask.

Also, why have the callback interface methods been made non-public? Would that 
be an incompatible change?

> Make AMRMClient support send increase container request and get 
> increased/decreased containers
> ----------------------------------------------------------------------------------------------
>                 Key: YARN-1509
>                 URL: https://issues.apache.org/jira/browse/YARN-1509
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan (No longer used)
>            Assignee: MENG DING
>         Attachments: YARN-1509.1.patch, YARN-1509.2.patch, YARN-1509.3.patch, 
> YARN-1509.4.patch, YARN-1509.5.patch
> As described in YARN-1197, we need add API in AMRMClient to support
> 1) Add increase request
> 2) Can get successfully increased/decreased containers from RM

This message was sent by Atlassian JIRA

Reply via email to