[ https://issues.apache.org/jira/browse/YARN-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14963474#comment-14963474 ]
Karthik Kambatla commented on YARN-4270: ---------------------------------------- Added comment too soon. Couple of comments: # FSAppAttempt#reservationExceedsThreshold: Instead of doing a ratio, would it be better to check {{existingReservations > Math.ceil(reservableNodes() * totalAvailableNodes)}}? We avoid a division and the check to see if there is at least one reservation is not necessary. # Nice tests. > Limit application resource reservation on nodes for non-node/rack specific > requests > ----------------------------------------------------------------------------------- > > Key: YARN-4270 > URL: https://issues.apache.org/jira/browse/YARN-4270 > Project: Hadoop YARN > Issue Type: Bug > Components: fairscheduler > Reporter: Arun Suresh > Assignee: Arun Suresh > Attachments: YARN-4270.1.patch, YARN-4270.2.patch, YARN-4270.3.patch, > YARN-4270.4.patch > > > I has been noticed that for off-switch requests, the FairScheduler reserves > resources on all nodes. This could lead to the entire cluster being > unavailable for all other applications. > Ideally, the reservations should be on a configurable number of nodes, > default 1. -- This message was sent by Atlassian JIRA (v6.3.4#6332)