[
https://issues.apache.org/jira/browse/YARN-4129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964142#comment-14964142
]
Sangjin Lee commented on YARN-4129:
-----------------------------------
bq. I was of diff understanding on this and also i had seen other classes like
ResourceTrackerService. I was of the understanding that super.serviceStart()
needs to be called first and super.serviceStop() to be called last.
Sounds good. I may well have understood the convention wrong.
There seems to be a findbugs warning. The above content seems to be empty for
some reason, but here is the real warning:
{code}
<file
classname='org.apache.hadoop.yarn.server.resourcemanager.metrics.TimelineServiceV2Publisher$TimelineV2EventHandler'>
<BugInstance type='BC_UNCONFIRMED_CAST' priority='Normal' category='STYLE'
message='Unchecked/unconfirmed cast from
org.apache.hadoop.yarn.server.resourcemanager.metrics.TimelineServiceV2Publisher$TimelineV2PublishEvent
to
org.apache.hadoop.yarn.server.resourcemanager.metrics.TimelineServiceV2Publisher$ApplicationFinishPublishEvent
in
org.apache.hadoop.yarn.server.resourcemanager.metrics.TimelineServiceV2Publisher$TimelineV2EventHandler.handle(TimelineServiceV2Publisher$TimelineV2PublishEvent)'
lineNumber='379'/>
</file>
{code}
Could you please address this findbugs warning too?
> Refactor the SystemMetricPublisher in RM to better support newer events
> -----------------------------------------------------------------------
>
> Key: YARN-4129
> URL: https://issues.apache.org/jira/browse/YARN-4129
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Attachments: YARN-4129-YARN-2928.002.patch,
> YARN-4129.YARN-2928.001.patch
>
>
> Currently to add new timeline event/ entity in RM side, one has to add a
> method in publisher and a method in handler and create a new event class
> which looks cumbersome and redundant. also further all the events might not
> be required to be published in V1 & V2. So adopting the approach similar to
> what was adopted in YARN-3045(NM side)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
