Steve Loughran updated YARN-4279:
    Attachment: YARN-4279-001.patch

patch 001, changes markers on newInstance methods. no tests -untestable

> Mark ApplicationId and ApplicationAttemptId static methods as @Public, 
> @Unstable
> --------------------------------------------------------------------------------
>                 Key: YARN-4279
>                 URL: https://issues.apache.org/jira/browse/YARN-4279
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 2.7.1
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: YARN-4279-001.patch
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
> The classes {{ApplicationId}} and {{ApplicationAttemptId}} both have 
> {{newInstance()}} methods tagged as {{@Private}}. Yet they are useful in 
> testing, as the alternative is to create and configure the PBImpl classes 
> -which are significantly more private.
> The fact that mapreduce's {{MRBuilderUtils}} uses one of the methods shows 
> that YARN apps do need access to the methods.
> Marking them as public would make it clear that other YARN apps were using 
> them for their production or test code, rather than today, where they are 
> used and depended on, yet without the YARN team's knowledge.

This message was sent by Atlassian JIRA

Reply via email to