[
https://issues.apache.org/jira/browse/YARN-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965685#comment-14965685
]
Jason Lowe commented on YARN-4281:
----------------------------------
The intent is to bring this code better inline with what's happening on
branch-2, now that YARN-3248 was committed to branch-2.7 (and broke the RM UI
as a result). As such I have a few whitespace nits on the patch which when
fixed should help remove some potentials for merge conflicts when
cherry-picking other changes from branch-2. For reference I was diffing the
patched version of AppBlock.java and RMAppBlock.java against commit
c9ee316045b83b18cb068aa4de739a1f4b50f02a which is where YARN-3544 went into
branch-2. Any diffs that don't belong to another commit delta between branch-2
and branch-2.7 are what's flagged below.
For this patch hunk, the original YARN-3248 did not have the appReport = null
line, just the appReport declaration. Also there's an additional whitespace
line that was added by this patch which should not be there:
{noformat:title=AppBlock.java}
@@ -87,8 +86,9 @@ protected void render(Block html) {
return;
}
- callerUGI = getCallerUGI();
- ApplicationReport appReport;
+
+ UserGroupInformation callerUGI = getCallerUGI();
+ ApplicationReport appReport = null;
try {
final GetApplicationReportRequest request =
GetApplicationReportRequest.newInstance(appID);
{noformat}
Similarly, the patch leaves an additional whitespace line where the import code
was deleted and adds a new whitespace line where it was added back in:
{noformat:title=RMAppBlock.java}
@@ -20,21 +20,14 @@
import static org.apache.hadoop.yarn.webapp.view.JQueryUI._INFO_WRAP;
-import java.security.PrivilegedExceptionAction;
-import java.util.Collection;
-import java.util.Set;
import org.apache.commons.lang.StringEscapeUtils;
import org.apache.commons.logging.Log;
[...]
import com.google.inject.Inject;
+
+import java.util.Collection;
+import java.util.Set;
+
public class RMAppBlock extends AppBlock{
private static final Log LOG = LogFactory.getLog(RMAppBlock.class);
{noformat}
> 2.7 RM app page is broken
> -------------------------
>
> Key: YARN-4281
> URL: https://issues.apache.org/jira/browse/YARN-4281
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Chang Li
> Assignee: Chang Li
> Priority: Blocker
> Attachments: YARN-4281-branch-2.7.patch, YARN-4281.2.7.modify.patch
>
>
> 2.7 RM app page is broken by the cherry pick of YARN-3248 on 23/Sep. It broke
> the work around 2.7 patch of YARN-3544 to let it still use container report.
> Currently, our cluster's 2.7 RM app page is completely broken due to 500
> error, which is caused by when user UGI is null, completed app can not
> retrieve its container report, and in that code path, it doesn't catch
> ContainerNotFoundException, but throw the exception, therefore cause the 500
> error.
> Running app is also broken because of the way it construct containerID by
> {code} "ContainerId.newContainerId(
> appAttemptReport.getApplicationAttemptId(), 1)"
> {code},
> which will not include epoch number in ID, so it will also get
> ContainerNotFoundException and throw 500 error.
> Propose to use the branch-2 version of YARN-3544, instead of the work around
> 2.7 patch because branch 2 patch on 2.7 is no longer blocked.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
