Karthik Kambatla commented on YARN-4243:

Thanks for the update, Xuan. Sorry for the delay in getting to this. 

Just one nit: To be consistent with the other config, can we call use 
zk-retries instead of zk.op.retries? I am +1 otherwise.

One other thing to consider - should we make the change to ActiveStandbyElector 
as a Common JIRA or at least create a Common JIRA and close it as part of this 
one, so the common and HDFS devs are aware of this change? They might want to 
update the way HDFS handles the retries situation as well. 

> Add retry on establishing Zookeeper conenction in 
> EmbeddedElectorService#serviceInit
> ------------------------------------------------------------------------------------
>                 Key: YARN-4243
>                 URL: https://issues.apache.org/jira/browse/YARN-4243
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-4243.1.patch, YARN-4243.2.1.patch, 
> YARN-4243.2.patch, YARN-4243.3.patch, YARN-4243.4.patch
> Right now, the RM would shut down if the zk connection is down when the RM do 
> the initialization. We need to add retry on this part

This message was sent by Atlassian JIRA

Reply via email to