Sunil G updated YARN-3216:
    Attachment: 0009-YARN-3216.patch

Hi [~leftnoteasy]
Thank you for sharing the comments. Updating patch addressing the same.

bq.2) Will tests fail if revert changes of TestNodeLabelContainerAllocation
Yes, tests will fail For example, if we do not give any label to {{submitApp}}, 
then it will try to allocate to default label. Because in MockRM, we set 
NO_LABEL in all am resource request by default. And 
{{MockRM.launchAndRegisterAM(app1, rm1, nm1);}}, will try to schedule to *nm1* 
which only takes "x". So AM will not be allocated, rather it will stay in 
scheduled state.
    MockNM nm1 = rm1.registerNode("h1:1234", 8000); // label = x
    rm1.registerNode("h2:1234", 8000); // label = y
    MockNM nm3 = rm1.registerNode("h3:1234", 8000); // label = <empty>

    // launch an app to queue a1 (label = x), and check all container will
    // be allocated in h1
    RMApp app1 = rm1.submitApp(200, "app", "user", null, "a1", "x");
    MockAM am1 = MockRM.launchAndRegisterAM(app1, rm1, nm1);

> Max-AM-Resource-Percentage should respect node labels
> -----------------------------------------------------
>                 Key: YARN-3216
>                 URL: https://issues.apache.org/jira/browse/YARN-3216
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Sunil G
>            Priority: Critical
>         Attachments: 0001-YARN-3216.patch, 0002-YARN-3216.patch, 
> 0003-YARN-3216.patch, 0004-YARN-3216.patch, 0005-YARN-3216.patch, 
> 0006-YARN-3216.patch, 0007-YARN-3216.patch, 0008-YARN-3216.patch, 
> 0009-YARN-3216.patch
> Currently, max-am-resource-percentage considers default_partition only. When 
> a queue can access multiple partitions, we should be able to compute 
> max-am-resource-percentage based on that.

This message was sent by Atlassian JIRA

Reply via email to