Varun Vasudev commented on YARN-4009:

[~jeagles] - with your patch, the timeline service will always require its own 
CORS configuration. Is my understanding correct? In that case, we should remove
+  /** Enables cross origin support for timeline server. Uses the filter
+   * in hadoop common instead of the timeline server specific one. */
+  public static final String TIMELINE_SERVICE_CROSS_ORIGIN_ENABLED =
+      TIMELINE_SERVICE_PREFIX + "cross-origin.enabled";
from YarnConfiguration.java.

The rest of the patch looks good to me.

> CORS support for ResourceManager REST API
> -----------------------------------------
>                 Key: YARN-4009
>                 URL: https://issues.apache.org/jira/browse/YARN-4009
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Prakash Ramachandran
>            Assignee: Varun Vasudev
>         Attachments: YARN-4009.001.patch, YARN-4009.002.patch, 
> YARN-4009.003.patch, YARN-4009.004.patch, YARN-4009.005.patch, 
> YARN-4009.006.patch, YARN-4009.007.patch, YARN-4009.LOGGING.patch, 
> YARN-4009.LOGGING.patch
> Currently the REST API's do not have CORS support. This means any UI (running 
> in browser) cannot consume the REST API's. For ex Tez UI would like to use 
> the REST API for getting application, application attempt information exposed 
> by the API's. 
> It would be very useful if CORS is enabled for the REST API's.

This message was sent by Atlassian JIRA

Reply via email to