Varun Vasudev updated YARN-4285:
    Attachment: YARN-4285.003.patch

bq. 1) Since ApplicationResourceUsageReport is public API, I suggest to rename 
parameter, getter/setter name from Perc to Percentage. Same as 



    if (rmContext.getScheduler() instanceof YarnScheduler) {
      calc = rmContext.getScheduler().getResourceCalculator();

rmContext.getScheduler() should be always YarnScheduler, correct? This check 
maybe not required.

Good catch! Fixed.

bq. 3) Is it better to change int percentage to float, for AppInfo and other 


bq. 4) Since this is not a trivial patch, could you add some tests to verify if 
SchedulerApplicationAttempt can return percentage properly?


> Display resource usage as percentage of queue and cluster in the RM UI
> ----------------------------------------------------------------------
>                 Key: YARN-4285
>                 URL: https://issues.apache.org/jira/browse/YARN-4285
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>            Reporter: Varun Vasudev
>            Assignee: Varun Vasudev
>         Attachments: YARN-4285.001.patch, YARN-4285.002.patch, 
> YARN-4285.003.patch
> Currently, we display the memory and vcores allocated to an app in the RM UI. 
> It would be useful to display the resources consumed as a %of the queue and 
> the cluster to identify apps that are using a lot of resources.

This message was sent by Atlassian JIRA

Reply via email to