Junping Du commented on YARN-3223:

Thanks [~brookz] for updating the patch! I am general fine with your approach 
also. However, I don't think we should involve a new parameter of boolean value 
to indicate the node is in decommissioning or not. RMNode itself 
(RMNode.getState()) is already include the necessary info, so the boolean 
parameter sounds like redundant. Isn't it?
-  public NodeUpdateSchedulerEvent(RMNode rmNode) {
+  public NodeUpdateSchedulerEvent(RMNode rmNode, boolean isDecommissioning) {
     this.rmNode = rmNode;
+    this.isDecommissioning = isDecommissioning;
I also notice many changes on test are related to this change. So remove this 
change could make your patch more concisely.

> Resource update during NM graceful decommission
> -----------------------------------------------
>                 Key: YARN-3223
>                 URL: https://issues.apache.org/jira/browse/YARN-3223
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>    Affects Versions: 2.7.1
>            Reporter: Junping Du
>            Assignee: Brook Zhou
>         Attachments: YARN-3223-v0.patch, YARN-3223-v1.patch
> During NM graceful decommission, we should handle resource update properly, 
> include: make RMNode keep track of old resource for possible rollback, keep 
> available resource to 0 and used resource get updated when
> container finished.

This message was sent by Atlassian JIRA

Reply via email to