[
https://issues.apache.org/jira/browse/YARN-4296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14972382#comment-14972382
]
Hadoop QA commented on YARN-4296:
---------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 20m 21s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 9m 25s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 11m 49s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 29s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 27s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 44s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 38s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 0m 57s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests | 7m 6s | Tests passed in
hadoop-yarn-applications-distributedshell. |
| | | 52m 59s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12768480/YARN-4296.0.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 7781fe1 |
| hadoop-yarn-applications-distributedshell test log |
https://builds.apache.org/job/PreCommit-YARN-Build/9559/artifact/patchprocess/testrun_hadoop-yarn-applications-distributedshell.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/9559/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/9559/console |
This message was automatically generated.
> DistributedShell Log.info is not friendly
> -----------------------------------------
>
> Key: YARN-4296
> URL: https://issues.apache.org/jira/browse/YARN-4296
> Project: Hadoop YARN
> Issue Type: Bug
> Components: applications/distributed-shell
> Affects Versions: 2.5.2, 2.7.1
> Reporter: Xiaowei Wang
> Fix For: 2.7.1
>
> Attachments: YARN-4296.0.patch
>
>
> In java/org/apache/hadoop/yarn/applications/distributedshell/Client.java,
> line 453，Log.info is not friendly ,I think,nodeAddress and its content should
> be separated with "="
> The origin Log.info is
> {noformat}
> 15/10/24 10:20:26 INFO distributedshell.Client: Got node report from ASM for,
> nodeId=cloud101414328.wd.nm.ss.nop:45454,
> nodeAddresscloud101414328.wd.nm.ss.nop:23999, nodeRackName/default-rack,
> nodeNumContainers19
> 15/10/24 10:20:26 INFO distributedshell.Client: Got node report from ASM for,
> nodeId=rsync.cloud10141032027.wd.nm.nop:45454,
> nodeAddressrsync.cloud10141032027.wd.nm.nop:23999, nodeRackName/default-rack,
> nodeNumContainers19
> {noformat}
> A better way is
> {noformat}
> 15/10/24 10:20:26 INFO distributedshell.Client: Got node report from ASM for,
> nodeId=cloud101414328.wd.nm.ss.nop:45454,
> nodeAddress=cloud101414328.wd.nm.ss.nop:23999, nodeRackName=/default-rack,
> nodeNumContainers=19
> 15/10/24 10:20:26 INFO distributedshell.Client: Got node report from ASM for,
> nodeId=rsync.cloud10141032027.wd.nm.nop:45454,
> nodeAddress=rsync.cloud10141032027.wd.nm.nop:23999,
> nodeRackName=/default-rack, nodeNumContainers=19
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
