[ https://issues.apache.org/jira/browse/YARN-3528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14973213#comment-14973213 ]
Hadoop QA commented on YARN-3528: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:red}-1{color} | pre-patch | 8m 23s | Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 8 new or modified test files. | | {color:green}+1{color} | javac | 7m 57s | There were no new javac warning messages. | | {color:green}+1{color} | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 1m 47s | There were no new checkstyle issues. | | {color:red}-1{color} | whitespace | 0m 1s | The patch has 5 line(s) that end in whitespace. Use git apply --whitespace=fix. | | {color:green}+1{color} | install | 1m 29s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 3m 5s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | common tests | 7m 6s | Tests passed in hadoop-common. | | {color:green}+1{color} | yarn tests | 8m 57s | Tests passed in hadoop-yarn-server-nodemanager. | | | | 39m 44s | | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12768599/YARN-3528-011.patch | | Optional Tests | javac unit findbugs checkstyle | | git revision | trunk / ab8eb87 | | Pre-patch Findbugs warnings | https://builds.apache.org/job/PreCommit-YARN-Build/9565/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-server-nodemanager.html | | whitespace | https://builds.apache.org/job/PreCommit-YARN-Build/9565/artifact/patchprocess/whitespace.txt | | hadoop-common test log | https://builds.apache.org/job/PreCommit-YARN-Build/9565/artifact/patchprocess/testrun_hadoop-common.txt | | hadoop-yarn-server-nodemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/9565/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/9565/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/9565/console | This message was automatically generated. > Tests with 12345 as hard-coded port break jenkins > ------------------------------------------------- > > Key: YARN-3528 > URL: https://issues.apache.org/jira/browse/YARN-3528 > Project: Hadoop YARN > Issue Type: Improvement > Affects Versions: 2.8.0 > Environment: ASF Jenkins > Reporter: Steve Loughran > Assignee: Brahma Reddy Battula > Priority: Blocker > Labels: test > Fix For: 2.8.0 > > Attachments: YARN-3528-002.patch, YARN-3528-003.patch, > YARN-3528-004.patch, YARN-3528-005.patch, YARN-3528-006.patch, > YARN-3528-007.patch, YARN-3528-008.patch, YARN-3528-009.patch, > YARN-3528-011.patch, YARN-3528-branch2.patch, YARN-3528.patch > > > A lot of the YARN tests have hard-coded the port 12345 for their services to > come up on. > This makes it impossible to have scheduled or precommit tests to run > consistently on the ASF jenkins hosts. Instead the tests fail regularly and > appear to get ignored completely. > A quick grep of "12345" shows up many places in the test suite where this > practise has developed. > * All {{BaseContainerManagerTest}} subclasses > * {{TestNodeManagerShutdown}} > * {{TestContainerManager}} > + others > This needs to be addressed through portscanning and dynamic port allocation. > Please can someone do this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)