[ 
https://issues.apache.org/jira/browse/YARN-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990881#comment-14990881
 ] 

Arun Suresh commented on YARN-2882:
-----------------------------------

Thanks for the patch [~kkaranasos]. The patch looks mostly good. Few minor nits 
:
# I feel that instead of adding another *newInstance* method in 
*ResourceRequest* class, maybe we replace this with some sort of builder 
pattern. for eg : something like so :
{noformat}
ReseourceRequest req = new 
ResourceRequestBuilder().setPripority(pri).setHostName(hostname).setContainerType(QUEUEABLE)...build();
{noformat}
(I understand.. this might impact other parts of the code, but I believe it 
would make it more extensible in the future.)
# in the *yarn_protos.proto* file, can we add *container_type* after the 
*node_label_expression* field (I feel newer fields should come later)

Also, looks like the patch does not apply correctly anymore, can you please 
rebase ?

> Introducing container types
> ---------------------------
>
>                 Key: YARN-2882
>                 URL: https://issues.apache.org/jira/browse/YARN-2882
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Konstantinos Karanasos
>            Assignee: Konstantinos Karanasos
>         Attachments: yarn-2882.patch
>
>
> This JIRA introduces the notion of container types.
> We propose two initial types of containers: guaranteed-start and queueable 
> containers.
> Guaranteed-start are the existing containers, which are allocated by the 
> central RM and are instantaneously started, once allocated.
> Queueable is a new type of container, which allows containers to be queued in 
> the NM, thus their execution may be arbitrarily delayed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to