[ 
https://issues.apache.org/jira/browse/YARN-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14991374#comment-14991374
 ] 

nijel commented on YARN-2934:
-----------------------------

thanks [~Naganarasimha] for the patch

Few minor comments/doubts

1.
{code}
FileStatus[] listStatus =
       fileSystem.listStatus(containerLogDir, new PathFilter() {
         @Override
         public boolean accept(Path path) {
           return FilenameUtils.wildcardMatch(path.getName(),
               errorFileNamePattern, IOCase.INSENSITIVE);
         }
       });
{code}
What if this give multiple error files ? 


2. 
{code}
 } catch (IOException e) {
        LOG.warn("Failed while trying to read container's error log", e);
      }
{code}
Can this be error log ? I think there should not be any exception in reading 
the file. If there is an error, better to log error log



> Improve handling of container's stderr 
> ---------------------------------------
>
>                 Key: YARN-2934
>                 URL: https://issues.apache.org/jira/browse/YARN-2934
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Gera Shegalov
>            Assignee: Naganarasimha G R
>            Priority: Critical
>         Attachments: YARN-2934.v1.001.patch, YARN-2934.v1.002.patch, 
> YARN-2934.v1.003.patch
>
>
> Most YARN applications redirect stderr to some file. That's why when 
> container launch fails with {{ExitCodeException}} the message is empty.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to