[ 
https://issues.apache.org/jira/browse/YARN-3980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14994799#comment-14994799
 ] 

Wangda Tan commented on YARN-3980:
----------------------------------

Just noticed this ticket. [~sunilg], since this patch is almost ready to go, if 
you think it's fine, could you update YARN-4292 to base on this one? And could 
you take a look at this patch to see if there's any changes need to merge?

[~goiri], thanks for working on this, two comments
{code}
352       public void setContainersUtilization(
353           ResourceUtilization containersUtilization) {
354         if (containersUtilization != null) {
355           this.containersUtilization = containersUtilization;
356         }
357       }
{code}
It seems SchedulerNode cannot update containerUtilization since it's always not 
null. I think you should directly update utilization when set.
And I suggest to update SchedulerNode.containersUtilization/nodeUtilization to 
use violate.

And for naming, I suggest to change getContainersUtilization in 
RMNode/SchedulerNode/RMNodeStatusEvent to get*Aggregated*ContainersUtilization, 
which is more straight forward to me.

> Plumb resource-utilization info in node heartbeat through to the scheduler
> --------------------------------------------------------------------------
>
>                 Key: YARN-3980
>                 URL: https://issues.apache.org/jira/browse/YARN-3980
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager, scheduler
>    Affects Versions: 2.7.1
>            Reporter: Karthik Kambatla
>            Assignee: Inigo Goiri
>         Attachments: YARN-3980-v0.patch, YARN-3980-v1.patch, 
> YARN-3980-v2.patch, YARN-3980-v3.patch, YARN-3980-v4.patch
>
>
> YARN-1012 and YARN-3534 collect resource utilization information for all 
> containers and the node respectively and send it to the RM on node heartbeat. 
> We should plumb it through to the scheduler so the scheduler can make use of 
> it. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to