[ 
https://issues.apache.org/jira/browse/YARN-4338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996241#comment-14996241
 ] 

Naganarasimha G R commented on YARN-4338:
-----------------------------------------

Hi [~xinwei],
In that case its expected to come through ApplicationMasterService , so may be 
its sufficient to rectify the test case with default label "" . 
[~sunilg] & [~wangda]
But as we are coming across this more frequently, how about correcting it with 
setting with Default Label when using other overloaded methods or even in the 
main overloaded method we can check for null and set to Default i.e. "" ?


> NPE in RegularContainerAllocator.preCheckForNewContainer()
> ----------------------------------------------------------
>
>                 Key: YARN-4338
>                 URL: https://issues.apache.org/jira/browse/YARN-4338
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Xinwei Qin 
>            Priority: Minor
>         Attachments: YARN-4338.001.patch
>
>
> The codes in RegularContainerAllocator.preCheckForNewContainer():
> {code}
>     if (anyRequest.getNodeLabelExpression()
>         .equals(RMNodeLabelsManager.NO_LABEL)) {
>       missedNonPartitionedRequestSchedulingOpportunity =
>           application
>               .addMissedNonPartitionedRequestSchedulingOpportunity(priority);
>     }
> {code}
> {code}anyRequest.getNodeLabelExpression(){code}may return null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to