Naganarasimha G R updated YARN-2934:
    Attachment: YARN-2934.v1.005.patch

Thanks for the comments [~varun_saxena],
bq. Pattern#compile incurs a performance overhead if called again and again.
thought of handling this based on further comments and also it was not in 
critical/repititive code flow but any way worth optimizing hence have done in 
this patch.

bq. Should we consider not starting up NM in this case(if config is wrong) ? 
Maybe its not that important a config to not start NM. An alert message should 
be enough.
As discussed alert is enough as its not critical.

bq. Moreover, you can also consider using Configuration#getPattern, but take 
care of using it only once.
Yep this would be usefull, and also takes care of your 2nd comment, hence using 
this. but adding one more additional method there to ignore the case.

> Improve handling of container's stderr 
> ---------------------------------------
>                 Key: YARN-2934
>                 URL: https://issues.apache.org/jira/browse/YARN-2934
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Gera Shegalov
>            Assignee: Naganarasimha G R
>            Priority: Critical
>         Attachments: YARN-2934.v1.001.patch, YARN-2934.v1.002.patch, 
> YARN-2934.v1.003.patch, YARN-2934.v1.004.patch, YARN-2934.v1.005.patch
> Most YARN applications redirect stderr to some file. That's why when 
> container launch fails with {{ExitCodeException}} the message is empty.

This message was sent by Atlassian JIRA

Reply via email to