Xuan Gong commented on YARN-4234:

Attached a new patch with the renamed configurations.

bq. CacheId -> TimelineEntityGroupId ? And similarly rename it everywhere. 


bq. Also move this to org.apache.hadoop.yarn.api.records.timeline.


bq. Move CacheIdProto from yarn_protos.proto also accordingly

I can not find a better place. Just keep it in yarn_protos.proto.

bq. Reorder the API parameters


bq. entity-file-fd.flush-interval-secs -> 


bq. Similarly entity-file-fd.clean-interval-sec and entity-file-fd.retain-secs


bq. Why do we need TIMELINE_SERVICE_PLUGIN_ENABLED especially if we also have 
this TimelineEntityGroupId/CacheId as part of the writer API? 


bq. TimelineClientImpl is doing two many things. Let's have a 
DirectTimelineWriter vs HDFSTimelineWriter which can encapsulate functionality.

Will do it later.

Also, I add a new configuration: TIMELINE_SERVICE_VERSION. So, if we want to 
use ats 1.5, we need set 1.5 for this configuration. And when we try to use new 
api for ats1.5, a sanity check would be enforced.

> New put APIs in TimelineClient for ats v1.5
> -------------------------------------------
>                 Key: YARN-4234
>                 URL: https://issues.apache.org/jira/browse/YARN-4234
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>         Attachments: YARN-4234.1.patch, YARN-4234.2.patch, 
> YARN-4234.20151109.patch, YARN-4234.20151110.1.patch, 
> YARN-4234.20151111.1.patch, YARN-4234.3.patch
> In this ticket, we will add new put APIs in timelineClient to let 
> clients/applications have the option to use ATS v1.5

This message was sent by Atlassian JIRA

Reply via email to