Joep Rottinghuis commented on YARN-4053:

Either throw exception, or document in javadoc that null is considered 0. For 
addition that would be reasonable, but either approach is fine (as long as the 
javadoc explains which approach was taken).
For comparison I suppose only null == null is reasonable. For null compared to 
anything else you can either assume 0 or throw an exception. Not sure that one 
can say that null is bigger or smaller than any other value.

Wrt comparable versus comparator you're correct. We're not comparing the 
ValueConverters themselves, but rather Numbers.

> Change the way metric values are stored in HBase Storage
> --------------------------------------------------------
>                 Key: YARN-4053
>                 URL: https://issues.apache.org/jira/browse/YARN-4053
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-4053-YARN-2928.01.patch, 
> YARN-4053-YARN-2928.02.patch, YARN-4053-feature-YARN-2928.03.patch, 
> YARN-4053-feature-YARN-2928.04.patch
> Currently HBase implementation uses GenericObjectMapper to convert and store 
> values in backend HBase storage. This converts everything into a string 
> representation(ASCII/UTF-8 encoded byte array).
> While this is fine in most cases, it does not quite serve our use case for 
> metrics. 
> So we need to decide how are we going to encode and decode metric values and 
> store them in HBase.

This message was sent by Atlassian JIRA

Reply via email to