Sangjin Lee commented on YARN-4053:

Sorry it took me awhile to review the latest patch. It looks good for the most 
part. I have a couple of minor comments.

- The name {{ValueConverterImpl}} threw me off a little because initially I 
thought it was about actual implementations of {{ValueConverter}}. It seems 
more like a {{ValueConverterFactory}}. I think we can go straight to 
{{GenericConverter.getIstance()}} and {{LongConverter.getInstance()}}. The 
factory seems like a little overkill.
- Can we change {{NumericValueConverter}} to use generics; e.g.
public interface NumericValueConverter extends ValueConverter,
    Comparator<T extends Number> {
? This can be even tighter than the current interface.

> Change the way metric values are stored in HBase Storage
> --------------------------------------------------------
>                 Key: YARN-4053
>                 URL: https://issues.apache.org/jira/browse/YARN-4053
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-4053-YARN-2928.01.patch, 
> YARN-4053-YARN-2928.02.patch, YARN-4053-feature-YARN-2928.03.patch, 
> YARN-4053-feature-YARN-2928.04.patch, YARN-4053-feature-YARN-2928.05.patch
> Currently HBase implementation uses GenericObjectMapper to convert and store 
> values in backend HBase storage. This converts everything into a string 
> representation(ASCII/UTF-8 encoded byte array).
> While this is fine in most cases, it does not quite serve our use case for 
> metrics. 
> So we need to decide how are we going to encode and decode metric values and 
> store them in HBase.

This message was sent by Atlassian JIRA

Reply via email to