Carlo Curino commented on YARN-3454:

[~asuresh] thanks for the prompt and thoughtful review. 

I agree with and have addressed all your comments. In particular, I am not 
using Resources.lessThan (which might trigger issues with the DRC as you 
suggested), but I am using Resources.fitsIn, which is implemented 
component-wise and independent from the ResourceCalculator ( and ideally will 
be evolved as Resource gets more dimensions).  I also added several more test 
cases for the subtractTestPositive to catch 
few of this corner cases.

Please let me know if this looks good. 

> RLESparseResourceAllocation does not handle removal of partial intervals (+ 
> introducing support for efficient "merge" operations) 
> ----------------------------------------------------------------------------------------------------------------------------------
>                 Key: YARN-3454
>                 URL: https://issues.apache.org/jira/browse/YARN-3454
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: 2.8.0, 2.7.1, 2.6.2
>            Reporter: Carlo Curino
>            Assignee: Carlo Curino
>         Attachments: YARN-3454.1.patch, YARN-3454.patch
> The RLESparseResourceAllocation.removeInterval(...) method handles well exact 
> match interval removals, but does not handles correctly partial overlaps. 
> In the context of this fix, we also introduced static methods to "merge" two 
> RLESparseResourceAllocation, while applying an operator in the process 
> (add/subtract/min/max/subtractTestPositive)

This message was sent by Atlassian JIRA

Reply via email to