Jason Lowe commented on YARN-4132:

Thanks for updating the patch!  I think we're close.

* The property docs should mention the fallback if unspecified, otherwise it's 
confusing to have no specified value in yarn-default
* The new createRetryPolicy method simply can be private and therefore doesn't 
need the decorators indicating it is
* Nit: new createRetryPolicy overload should have Configuration as first 
parameter for consistency with existing method.

> Nodemanagers should try harder to connect to the RM
> ---------------------------------------------------
>                 Key: YARN-4132
>                 URL: https://issues.apache.org/jira/browse/YARN-4132
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Chang Li
>            Assignee: Chang Li
>         Attachments: YARN-4132.2.patch, YARN-4132.3.patch, YARN-4132.4.patch, 
> YARN-4132.5.patch, YARN-4132.6.2.patch, YARN-4132.6.patch, YARN-4132.patch
> Being part of the cluster, nodemanagers should try very hard (and possibly 
> never give up) to connect to a resourcemanager. Minimally we should have a 
> separate config to set how aggressively a nodemanager will connect to the RM 
> separate from what clients will do.

This message was sent by Atlassian JIRA

Reply via email to