[
https://issues.apache.org/jira/browse/YARN-3980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020785#comment-15020785
]
Karthik Kambatla commented on YARN-3980:
----------------------------------------
Neat test using the MiniYarnCluster.
Comments on the patch (hopefully, the last set), assuming the patch adds only
test-related code.
# The new tests have spurious exceptions in the declaration.
# The tests sleep for 2 seconds waiting for the heartbeat to propagate. Can we
lower any configured timeouts to avoid this long sleep?
# javadoc is off in the new test class - can we fix them? Looks like the params
in javadoc don't match the args in the declaration. I am comfortable with not
adding params to the javadoc since they are mostly private methods.
# verifySimulatedUtilization doesn't need to take any arguments; nodeStatus is
already private and can be used directly? The sleep could also go there.
# You could specify timeouts on the tests - would recommend being conservative
to avoid the test getting killed on Jenkins.
> Plumb resource-utilization info in node heartbeat through to the scheduler
> --------------------------------------------------------------------------
>
> Key: YARN-3980
> URL: https://issues.apache.org/jira/browse/YARN-3980
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager, scheduler
> Affects Versions: 2.7.1
> Reporter: Karthik Kambatla
> Assignee: Inigo Goiri
> Attachments: YARN-3980-v0.patch, YARN-3980-v1.patch,
> YARN-3980-v2.patch, YARN-3980-v3.patch, YARN-3980-v4.patch,
> YARN-3980-v5.patch, YARN-3980-v6.patch, YARN-3980-v7.patch
>
>
> YARN-1012 and YARN-3534 collect resource utilization information for all
> containers and the node respectively and send it to the RM on node heartbeat.
> We should plumb it through to the scheduler so the scheduler can make use of
> it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
