[ 
https://issues.apache.org/jira/browse/YARN-4365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025470#comment-15025470
 ] 

Jason Lowe commented on YARN-4365:
----------------------------------

Rather than poking the store into the manager object, we don't need the manager 
object at all.  We can just test the store object directly.  Note how the test 
is simply using the manager object as a place to hold the store but only ever 
manipulates the store directly by reaching into the manager object.


> FileSystemNodeLabelStore should check for root dir existence on startup
> -----------------------------------------------------------------------
>
>                 Key: YARN-4365
>                 URL: https://issues.apache.org/jira/browse/YARN-4365
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.7.2
>            Reporter: Jason Lowe
>            Assignee: Kuhu Shukla
>         Attachments: YARN-4365-1.patch, YARN-4365-2.patch
>
>
> If the namenode is in safe mode for some reason then FileSystemNodeLabelStore 
> will prevent the RM from starting since it unconditionally tries to create 
> the root directory for the label store.  If the root directory already exists 
> and no labels are changing then we shouldn't prevent the RM from starting 
> even if the namenode is in safe mode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to