Tsuyoshi Ozawa commented on YARN-4348:

Ran test since last Jenkins failed to launch. javadoc seems to be false 
positive since this patch doesn't include any changes of javadocs.

-1 overall.  

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
                        Please justify why no new tests are needed for this 
                        Also please list what manual steps were performed to 
verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated 2079 warning 

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version ) 

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

[~jianhe] could you take a look at latest patch?

> ZKRMStateStore.syncInternal should wait for zkResyncWaitTime instead of 
> zkSessionTimeout
> ----------------------------------------------------------------------------------------
>                 Key: YARN-4348
>                 URL: https://issues.apache.org/jira/browse/YARN-4348
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.7.2, 2.6.2
>            Reporter: Tsuyoshi Ozawa
>            Assignee: Tsuyoshi Ozawa
>            Priority: Blocker
>         Attachments: YARN-4348-branch-2.7.002.patch, 
> YARN-4348-branch-2.7.003.patch, YARN-4348-branch-2.7.004.patch, 
> YARN-4348.001.patch, YARN-4348.001.patch, log.txt
> Jian mentioned that the current internal ZK configuration of ZKRMStateStore 
> can cause a following situation:
> 1. syncInternal timeouts, 
> 2. but sync succeeded later on.
> We should use zkResyncWaitTime as the timeout value.

This message was sent by Atlassian JIRA

Reply via email to