Wangda Tan commented on YARN-4309:

Thanks for reply, make sense to me.

Few comments:
- Could you make sure container process will be launched even if copy script or 
list folder command fails?
- Could you add echo command (something like echo "Printing container launch 
debug info...") to container_launch.sh? (After following "if")
362         if (getConf() != null && getConf().getBoolean(
363             YarnConfiguration.NM_LOG_CONTAINER_DEBUG_INFO,
364             YarnConfiguration.DEFAULT_NM_LOG_CONTAINER_DEBUG_INFO)) {
- Add a test to verify log aggregation result contains such debugging output?
- Could you upload a sample container_launch.sh for easier review? 

> Add debug information to application logs when a container fails
> ----------------------------------------------------------------
>                 Key: YARN-4309
>                 URL: https://issues.apache.org/jira/browse/YARN-4309
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>            Reporter: Varun Vasudev
>            Assignee: Varun Vasudev
>         Attachments: YARN-4309.001.patch, YARN-4309.002.patch, 
> YARN-4309.003.patch, YARN-4309.004.patch, YARN-4309.005.patch, 
> YARN-4309.006.patch, YARN-4309.007.patch
> Sometimes when a container fails, it can be pretty hard to figure out why it 
> failed.
> My proposal is that if a container fails, we collect information about the 
> container local dir and dump it into the container log dir. Ideally, I'd like 
> to tar up the directory entirely, but I'm not sure of the security and space 
> implications of such a approach. At the very least, we can list all the files 
> in the container local dir, and dump the contents of launch_container.sh(into 
> the container log dir).
> When log aggregation occurs, all this information will automatically get 
> collected and make debugging such failures much easier.

This message was sent by Atlassian JIRA

Reply via email to