Kuhu Shukla commented on YARN-4413:

Small comment on the patch, 
   new RMNodeEvent(entry.getKey(), RMNodeEventType.DECOMMISSION));
} else if (entry.getValue().getState() == NodeState.DECOMMISSIONED) {

This wont ever evaluate for the same reason as above. AFAIK, decomm-ed nodes 
are part of inactive list alone while {{entry}} is traversing getRMNodes() 
list, always returning null and if condition will not evaluate to true any 
time. Please let me know if I am missing something here.

> Nodes in the includes list should not be listed as decommissioned in the UI
> ---------------------------------------------------------------------------
>                 Key: YARN-4413
>                 URL: https://issues.apache.org/jira/browse/YARN-4413
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>    Affects Versions: 2.7.1
>            Reporter: Daniel Templeton
>            Assignee: Daniel Templeton
>         Attachments: YARN-4413.001.patch
> If I decommission a node and then move it from the excludes list back to the 
> includes list, but I don't restart the node, the node will still be listed by 
> the web UI as decomissioned until either the NM or RM is restarted.  Ideally, 
> removing the node from the excludes list and putting it back into the 
> includes list should cause the node to be reported as shutdown instead.
> CC [~kshukla]

This message was sent by Atlassian JIRA

Reply via email to