Junping Du commented on YARN-4403:

It depends on if any consumer of SystemClock are using it to track absolute 
time but not for duration or interval. I didn't check other calling places in 
YARN/MR, also theoretically, it could be consumers outside of YARN given this a 
public API. 
We may consider to mark this API as deprecated later if we check all known 
calling places are for duration or interval only. But for now, it could be 
better to keep annotation no changed but with NOTE.

> (AM/NM/Container)LivelinessMonitor should use monotonic time when calculating 
> period
> ------------------------------------------------------------------------------------
>                 Key: YARN-4403
>                 URL: https://issues.apache.org/jira/browse/YARN-4403
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Critical
>         Attachments: YARN-4403-v2.patch, YARN-4403.patch
> Currently, (AM/NM/Container)LivelinessMonitor use current system time to 
> calculate a duration of expire which could be broken by settimeofday. We 
> should use Time.monotonicNow() instead.

This message was sent by Atlassian JIRA

Reply via email to