[
https://issues.apache.org/jira/browse/YARN-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Payne updated YARN-4225:
-----------------------------
Attachment: YARN-4225.004.patch
Thanks very much [~leftnoteasy], for your review and helpful comments.
{quote}
I'm OK with both approach - existing one in latest patch or simply return false
if there's no such field in proto.
{quote}
So, if I understand correctly, you are okay with
{{QueueInfo#getPreemptionDisabled}} returning {{Boolean}} with the possibility
of returning {{null}} if the field doesn't exist. With that understanding, I'm
leaving that in the latest patch.
{quote}
2) For QueueCLI, is it better to print "preemption is disabled/enabled" instead
of "preemption status: disabled/enabled"?
{quote}
Actually, I think that leaving it as "Preemption : disabled/enabled" is more
consistent with the way the other properties are displayed. What do you think?
{quote}
3) Is it possible to add a simple test to verify end-to-end behavior?
{quote}
I added a couple of tests to {{TestYarnCLI}}. Good suggestion.
> Add preemption status to yarn queue -status for capacity scheduler
> ------------------------------------------------------------------
>
> Key: YARN-4225
> URL: https://issues.apache.org/jira/browse/YARN-4225
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacity scheduler, yarn
> Affects Versions: 2.7.1
> Reporter: Eric Payne
> Assignee: Eric Payne
> Priority: Minor
> Attachments: YARN-4225.001.patch, YARN-4225.002.patch,
> YARN-4225.003.patch, YARN-4225.004.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
