Li Lu commented on YARN-4356:

Thanks [~sjlee0]!
bq. The v.1 behavior should be essentially the same as today. The existing v.1 
behavior is to check TIMELINE_SERVICE_ENABLED and then 
RM_SYSTEM_METRICS_PUBLISHER_ENABLED. You'll see that the current patch checks 
RM_SYSTEM_METRICS_PUBLISHER_ENABLED. I do see that it's checking strictly for 
version = 1. I'll change it to check for version < 2 so it can match 1.5 as 

Sorry about the confusion here but I was talking about this part of the code:
223         // initialize the metrics publisher if the timeline service v.2 is 
224         // and the system publisher is enabled
225         Configuration conf = context.getConf();
226         if (YarnConfiguration.timelineServiceV2Enabled(conf) &&
227             YarnConfiguration.systemMetricsPublisherEnabled(conf)) {
228           LOG.info("YARN system metrics publishing service is enabled");
229           nmMetricsPublisher = createNMTimelinePublisher(context);
230           context.setNMTimelinePublisher(nmMetricsPublisher);
231         }

Looks like in ATS v1.x branch we don't have the nmMetricsPublisher so it's 
fine? Just want to double check this part. 

> ensure the timeline service v.2 is disabled cleanly and has no impact when 
> it's turned off
> ------------------------------------------------------------------------------------------
>                 Key: YARN-4356
>                 URL: https://issues.apache.org/jira/browse/YARN-4356
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Sangjin Lee
>            Priority: Critical
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-4356-feature-YARN-2928.002.patch, 
> YARN-4356-feature-YARN-2928.003.patch, 
> YARN-4356-feature-YARN-2928.poc.001.patch
> For us to be able to merge the first milestone drop to trunk, we want to 
> ensure that once disabled the timeline service v.2 has no impact from the 
> server side to the client side. If the timeline service is not enabled, no 
> action should be done. If v.1 is enabled but not v.2, v.1 should behave the 
> same as it does before the merge.

This message was sent by Atlassian JIRA

Reply via email to