[ 
https://issues.apache.org/jira/browse/YARN-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15049982#comment-15049982
 ] 

Naganarasimha G R commented on YARN-4356:
-----------------------------------------

Hi [~sjlee0],
bq. Right now those null checks are still limited to a couple of files. 
Although it may not be ideal, it is still manageable?
Its not a blocking thing and its just will help it in keeping it clean so no 
issues we can go ahead for this patch will try to take care in one of my other 
patches related to NMMetricsPublisher.

bq. Hmm, I know it's not great having 2 similar-sounding config params, but 
there is also RM_SYSTEM_METRICS_PUBLISHER_DISPATCHER_POOL_SIZE, so this might 
also make this patch a little bigger.
Ok we can take care in another jira, but 
YarnConfiguration.SYSTEM_METRICS_PUBLISHER_ENABLED and 
YarnConfiguration.RM_SYSTEM_METRICS_PUBLISHER_ENABLED was introduced because 
version was not there .  



> ensure the timeline service v.2 is disabled cleanly and has no impact when 
> it's turned off
> ------------------------------------------------------------------------------------------
>
>                 Key: YARN-4356
>                 URL: https://issues.apache.org/jira/browse/YARN-4356
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Sangjin Lee
>            Priority: Critical
>              Labels: yarn-2928-1st-milestone
>         Attachments: YARN-4356-feature-YARN-2928.002.patch, 
> YARN-4356-feature-YARN-2928.003.patch, YARN-4356-feature-YARN-2928.004.patch, 
> YARN-4356-feature-YARN-2928.005.patch, 
> YARN-4356-feature-YARN-2928.poc.001.patch
>
>
> For us to be able to merge the first milestone drop to trunk, we want to 
> ensure that once disabled the timeline service v.2 has no impact from the 
> server side to the client side. If the timeline service is not enabled, no 
> action should be done. If v.1 is enabled but not v.2, v.1 should behave the 
> same as it does before the merge.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to