[
https://issues.apache.org/jira/browse/YARN-4340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Po updated YARN-4340:
--------------------------
Attachment: YARN-4340.v8.patch
Thanks Subru for the comments. I have taken all your recommendations, except
for the following:
The startTime and endTime wasn't a typo - I actually intended on selecting all
active reservations within the time interval. that's why only reservations that
ended after the selection startTime, and reservations that start before or on
the selection endTime are included in the response.
In ReservationInputValidator, I didn't want to create the error strings from
getPlanFromQueue because it almost seems like we are bending over backwards to
prevent repeated code. The reason is because validateReservation uses this
method, and has a drastically different error message, and it doesn't seem easy
to reword it to fit into the pattern of the other error messages. I have
instead overloaded the method so that users can optionally pass in the error
messages. Otherwise, the defaults will be used.
> Add "list" API to reservation system
> ------------------------------------
>
> Key: YARN-4340
> URL: https://issues.apache.org/jira/browse/YARN-4340
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacityscheduler, fairscheduler, resourcemanager
> Reporter: Carlo Curino
> Assignee: Sean Po
> Attachments: YARN-4340.v1.patch, YARN-4340.v2.patch,
> YARN-4340.v3.patch, YARN-4340.v4.patch, YARN-4340.v5.patch,
> YARN-4340.v6.patch, YARN-4340.v7.patch, YARN-4340.v8.patch
>
>
> This JIRA tracks changes to the APIs of the reservation system, and enables
> querying the reservation system on which reservation exists by "time-range,
> reservation-id".
> YARN-4420 has a dependency on this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
