[ 
https://issues.apache.org/jira/browse/YARN-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15053064#comment-15053064
 ] 

Sunil G commented on YARN-4441:
-------------------------------

hi [~mohdshahidkhan]
I still not very much liking the idea of throwing some new exceptions in this 
context.
There were a series of discussions happened in YARN-107 for same, and as per a 
common consensus this current approach is taken 
[YARN-107:comments|https://issues.apache.org/jira/browse/YARN-107?focusedCommentId=13720845&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13720845].
 In my opinion, user wants to kill application due to some potential reason and 
that operation's intend  is to bring down the app. So if the app is in its 
final states, then its clearly fine that app will be shutdown. So throwing a 
new exception is not much needed. 
Coming to audit log, we have only success and failure in auditlog. And here we 
have the operation result as success eventhough kill doesnt happen (app is 
already finished/completed). So writing failure audit log is in-appropriate. 
Hence I think if needed, we can try to improve audit log success message to 
have some custom input which can give some details here. cc/[~rohithsharma] 
Thoughts?

> Kill application request from the webservice(ui) is showing success even for 
> the finished applications
> ------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-4441
>                 URL: https://issues.apache.org/jira/browse/YARN-4441
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Mohammad Shahid Khan
>            Assignee: Mohammad Shahid Khan
>
> If the application is already finished ie either failled, killed, or succeded
> the kill operation should not be logged as success. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to